On Fri, Jun 24, 2011 at 03:35:08PM -0400, S. Massy wrote:
> On Fri, Jun 24, 2011 at 02:32:37PM +0200, Philipp ??berbacher wrote:
Can we drop back into reality please ?
The Kmeterdsp class is one of the best commented little
pieces of C++ code I've written. There's a comment for
almost every line of code. The comments do make it very
clear how it works. If that isn't sufficient, I suggest
to just leave it alone.
The class doesn't depend on being called by a jack client.
Nor does it depend on any X11 or event delivery framework.
There is one undocumented feature: the 'int n' parameter
for process() should be equal to the 'fsize' parameter to
init(), and it should be a multiple of four. So I should
probably just remove that parameter to process(). Or make
process() independent of the period size.
Even if this condition is not satisfied, the only difference
would be a change in the hold time and fallback rate of the
peak indication, which probably would go unnoticed.
Linux-audio-user mailing list