*** ColaEuphoria has joined #lv2 | 01:03 | |
*** edogawa has joined #lv2 | 05:31 | |
*** ColaEuphoria has quit IRC | 06:34 | |
*** ricardocrudo has joined #lv2 | 08:29 | |
*** ventosus has joined #lv2 | 08:51 | |
*** ricardocrudo has quit IRC | 09:27 | |
*** falktx has joined #lv2 | 09:28 | |
*** ventosus has quit IRC | 09:40 | |
*** ricardocrudo has joined #lv2 | 09:41 | |
*** Galik has quit IRC | 10:56 | |
*** ventosus has joined #lv2 | 11:11 | |
falktx | drobilla: can you push the latest changes to github mirror? | 12:08 |
---|---|---|
*** Galik has joined #lv2 | 12:23 | |
drobilla | Thought I had a push hook for that... | 13:30 |
drobilla | falktx: done | 13:30 |
*** NickSB2_ has quit IRC | 13:53 | |
falktx | drobilla: is there an ingen command to delete all plugins at once? | 13:57 |
falktx | drobilla: right now I'm caching the existing plugins and calling delete on each one, isn't there a better way...? | 13:58 |
falktx | something that resets/clears the full state | 13:58 |
*** NickSB2_ has joined #lv2 | 15:10 | |
*** falktx has quit IRC | 15:51 | |
*** sigma6 has quit IRC | 16:06 | |
*** rncbc has joined #lv2 | 16:10 | |
*** falktx has joined #lv2 | 16:49 | |
rncbc | drobilla: hi | 17:13 |
rncbc | drobilla: jfyi. new patch replaces one from yesterday -> http://dev.drobilla.net/ticket/1087 | 17:16 |
*** falktx has quit IRC | 17:17 | |
*** HarryHaaren has joined #lv2 | 17:21 | |
*** falktx has joined #lv2 | 17:28 | |
*** ssj71 has joined #lv2 | 17:56 | |
ssj71 | apparently I have committed something egregious... | 17:57 |
ssj71 | rgareus: I have not seen any of my UIs crashing | 17:58 |
rgareus | ssj71: drobilla fixed it in suil. the instatiate code of a GUI has a LV2UI_Widget* widget; if your plugin is an X11UI you must set this to the X11 window ID | 18:00 |
rgareus | ssj71: it was previously only malloc()ed in suil and hence undefined. | 18:01 |
rgareus | ssj71: the host later uses it as valid window-ID (to pass keyboard shortcut, resize events etc etc). | 18:01 |
ssj71 | ok, so then the resize extension would not be necesssary? | 18:01 |
*** HarryHaaren has quit IRC | 18:02 | |
rgareus | ssj71: the other way round'. resize extension if your your plugin to resize. | 18:03 |
rgareus | ssj71: not seeing crashes, but you probably have messages from libxcb: invalid window-ID in the commandline | 18:04 |
ssj71 | hmm. well I'll try to set the LV2_widget first and then see what happens | 18:04 |
rgareus | ssj71: I have not tested with your plugins, but harry's plugis have tjem | 18:04 |
falktx | that thing is useless for x11 windows | 18:04 |
falktx | there's ui:parent to set the window ID | 18:04 |
ssj71 | then mine surely do. I copied his verbatim (he's since refactored avtk immensely) | 18:05 |
falktx | infamous and harry's plugins don't use the lv2_widget at all | 18:05 |
falktx | ssj71: correct? | 18:05 |
rgareus | falktx: that's also the other way 'round host pases the "parent" to the client and the client (plugin GUI) add itself to it | 18:05 |
ssj71 | falktx: correct, but I've been told now that that is bad | 18:05 |
falktx | hmmm | 18:05 |
rgareus | falktx: but for a host to pass X11 events to the client you need the X11 window (id) | 18:05 |
falktx | ..why do we need to keep changing things....!? | 18:06 |
rgareus | falktx: Window is just a 32bit int. | 18:06 |
rgareus | falktx: it has always been like that | 18:06 |
falktx | ok | 18:06 |
rgareus | falktx: that's really X11'89 | 18:06 |
falktx | then I don't need to do anything | 18:06 |
rgareus | falktx: no | 18:06 |
rgareus | all is fine. | 18:06 |
falktx | rgareus: is the host expected to do something with the x11 window of the plugin ui? | 18:06 |
falktx | I just let the plugin do its business | 18:07 |
rgareus | falktx: in the X11 warpped in gtk case the ID is needed to forward keyboard events and resize requests | 18:07 |
falktx | oh yeah, fancy embedding stuff | 18:07 |
falktx | I just show the plugin window as-is | 18:07 |
rgareus | falktx: yes, you're fine there. | 18:08 |
rgareus | falktx: if you embedd it, I expect in in QT you'll have to send X11 events to the X11 plugin (from the QT callback slot, QT abstracts those for the host) | 18:09 |
rgareus | the embedded X11 window will not see the events otherwise | 18:09 |
ssj71 | rgareus: so do I need to remove/change anything or just add returning the x11 id as the lv2_widget? | 18:10 |
rgareus | ssj71: if you can get the X11 Window. *widget = w; | 18:10 |
rgareus | ssj71: if not, it'd be good practice to at least zero it. *widget = NULL; | 18:11 |
ssj71 | a'ight. I can manage that | 18:11 |
falktx | rgareus: the host can just zero it before sending it to the plugin | 18:12 |
falktx | then check if it was modified or not | 18:12 |
falktx | simple | 18:12 |
rgareus | falktx: that's what suil does now (since 2 or 3 days) | 18:12 |
rgareus | falktx: it didn't do that before. | 18:12 |
falktx | hahaha | 18:12 |
falktx | omg | 18:12 |
falktx | I just wish jalv.qt4/5 to work nicely one day | 18:13 |
rgareus | http://lv2plug.in/doc/html/group__ui.html#a8dcbd2307b630c0b77e254cf3cc35913 says "The UI points this at its main widget" | 18:14 |
*** HarryHaaren has joined #lv2 | 18:14 | |
falktx | I always felt harry's code was a bit weird there | 18:16 |
falktx | it just ignored that var | 18:16 |
falktx | speaking of him... | 18:16 |
rgareus | falktx: not quite. harry's plugin set it to the FLTK Window. that's "almost" correct it were if the plugin was a "LV2::fltkUI" | 18:17 |
*** NickSB2_ has quit IRC | 18:19 | |
rgareus | he said it's a won't fix and the bright future is openAVtk (pugl based, gets this right) | 18:19 |
falktx | then I saw some old code I guess | 18:19 |
rgareus | falktx: https://github.com/harryhaaren/openAV-ArtyFX/blob/master/ducka/gui/ducka_ui.cxx#L89 | 18:25 |
rgareus | the first member https://github.com/harryhaaren/openAV-ArtyFX/blob/master/ducka/gui/ducka_widget.h#L14 is a Fl_Double_Window *window; | 18:26 |
rgareus | http://www.fltk.org/documentation.php/doc-1.1/osissues.html | 18:27 |
rgareus | it should simplit assign fl_xid() of that window | 18:27 |
rgareus | or the private fl_window; | 18:28 |
*** HarryHaaren has quit IRC | 18:31 | |
*** uncle-j_j has joined #lv2 | 18:32 | |
*** HarryHaaren has joined #lv2 | 18:45 | |
*** HarryHaaren has quit IRC | 18:47 | |
*** deva has joined #lv2 | 19:03 | |
falktx | n one should use fltk for plugins to begin with :) | 19:23 |
falktx | *n | 19:23 |
falktx | *no | 19:23 |
*** falktx has quit IRC | 19:26 | |
*** ricardocrudo has quit IRC | 19:27 | |
*** nicksters has joined #lv2 | 19:33 | |
*** deva has quit IRC | 19:35 | |
ssj71 | it appears fl_xid is broken in NTK | 19:40 |
ssj71 | is there actually an objective reason not to use fltk for plugins? | 19:58 |
*** curlymorphic has joined #lv2 | 20:37 | |
*** nicksters has quit IRC | 20:44 | |
*** nicksters has joined #lv2 | 20:44 | |
*** son0p has joined #lv2 | 20:45 | |
*** ventosus has left #lv2 | 20:53 | |
rgareus | ssj71: the blocking menu and file-window IIRC | 20:54 |
rgareus | ssj71: and fltk itself is just ugly on X11. it uses the ancient x11-drawing primitives. not antialiased | 20:54 |
rgareus | the objective reason against all major toolkits: they don't have audio-specific widgets. | 20:55 |
ssj71 | ok. nothing catastrophic | 21:05 |
ssj71 | I do need to figure out how to get fl_xid working though | 21:05 |
*** ricardocrudo has joined #lv2 | 21:07 | |
*** tytel has joined #lv2 | 21:08 | |
*** nicksters has quit IRC | 21:37 | |
*** nicksters has joined #lv2 | 21:39 | |
*** uncle-j_j1 has joined #lv2 | 21:41 | |
*** uncle-j_j has quit IRC | 21:42 | |
ssj71 | some days I feel like I should just throw my computer over the bridge and start digging ditches or something | 21:46 |
ssj71 | rgareus: so... I've done that now, should I expect any change in behaviour or... | 21:49 |
rgareus | ssj71: can your plugins be resized? do they accept keyboard entry? | 21:53 |
rgareus | ssj71: if so when swalled in e.g. jalv.gtk or ardour that should work now | 21:53 |
ssj71 | no keyboard entry | 21:53 |
ssj71 | resizing does the same thing it did before | 21:53 |
ssj71 | the gui doesn't actually change size, just the surrounding window | 21:54 |
ssj71 | this is in ardour 4.2 | 21:54 |
ssj71 | probably need bleeding edge suil and company right? | 21:54 |
rgareus | ssj71: with new suil (recent git) it now should be centered | 21:55 |
*** six6110 has joined #lv2 | 21:55 | |
ssj71 | my guis are resizable, will they resize? | 21:56 |
rgareus | I checked with Harry's plugins (they don't since no X11 ID is returned) but other fixed-sized X11 plugins now are properly centered | 21:56 |
rgareus | ssj71: yes | 21:56 |
ssj71 | WOOT! tiling! :) | 21:56 |
ssj71 | if you want to test the change you can build stuck from the devel branch | 21:57 |
ssj71 | otherwise I'll get back to you when I have time to update suil | 21:58 |
rgareus | tiling? | 21:58 |
ssj71 | daws don't really work with tiling WMs | 21:58 |
ssj71 | or rather, most plugins don't, but mine do | 21:58 |
*** ricardocrudo has quit IRC | 21:58 | |
rgareus | aah got you. I thought the plugin display was tiled (cropped and repeated) | 21:59 |
ssj71 | because tiled windows always have various aspect ratios | 21:59 |
rgareus | ssj71: http://dev.drobilla.net/attachment/ticket/1085/commit-d770060.diff adds aspect ratio constraints | 21:59 |
rgareus | ssj71: if your plugin was to report it, they'll be honored | 21:59 |
ssj71 | but thats exactly the point, I want plugins to use any aspect ratio. the infamous plugins do | 22:00 |
rgareus | in any case that's an example where XResizeWindow(GDK_WINDOW_XDISPLAY(window), ... ) is called and window is what your plugin returns | 22:00 |
rgareus | ssj71: in that case, don't set X-Window hints :) | 22:00 |
rgareus | by default all aspect-ratios work | 22:00 |
ssj71 | http://4.bp.blogspot.com/-DubiPy1ooiI/U-kn1dk7D_I/AAAAAAAAAHQ/kQSoQB6OfrY/s1600/result.png | 22:01 |
rgareus | but in some cases it makes sense to allow resizing BUT with constrains (min, max size, aspect,...) | 22:01 |
ssj71 | agreed. | 22:01 |
rgareus | ssj71: right, you do that yourself. | 22:01 |
*** uncle-j_j1 has quit IRC | 22:02 | |
ssj71 | casynth fills the window and resizes widgets to the constraining dimension, so it's more sensitive to extremes | 22:02 |
ssj71 | but still, does as its told | 22:02 |
ssj71 | http://3.bp.blogspot.com/-7K3Lq2wgmbQ/VVKNUaS0_UI/AAAAAAAAAL8/rhXEMBQ6I-w/s1600/2015-05-12-172856_2880x1800_scrot.png | 22:03 |
* rgareus likes scalable plugin GUIs | 22:04 | |
*** nicksters has quit IRC | 22:05 | |
ssj71 | I'm a big fan. It was more or less the #1 priority in choosing how I implemented guis | 22:05 |
ssj71 | for better or worse | 22:05 |
*** edogawa has quit IRC | 22:33 | |
*** curlymorphic has quit IRC | 22:44 | |
*** rncbc has quit IRC | 23:00 |
Generated by irclog2html.py 2.13.0 by Marius Gedminas - find it at mg.pov.lt!