| *** gianMOD_ has joined #lv2 | 00:20 | |
| *** gianMOD has quit IRC | 00:23 | |
| *** Magnus_RM has quit IRC | 00:24 | |
| *** gianMOD_ has quit IRC | 00:25 | |
| *** gianMOD has joined #lv2 | 01:26 | |
| *** gianMOD has quit IRC | 01:31 | |
| *** wend has joined #lv2 | 01:42 | |
| wend | Hey guys. | 01:42 |
|---|---|---|
| wend | Anyone free for a few mins? | 01:42 |
| rgareus | wend: I'll check tomorrow. too late for me now | 03:37 |
| rgareus | wend: could you post the complete code? maybe it's as simple as not hooking up the control inputs | 03:38 |
| rgareus | wend: if you try this in ardour it won't work (due to inline-processing) | 03:39 |
| rgareus | wend: in jalv it shoudl work | 03:39 |
| rgareus | w/inline processing: output_left == input_left | 03:39 |
| rgareus | wend: line 42 modifies output_left | 03:39 |
| rgareus | wend: line 45 probably expects the original value | 03:40 |
| rgareus | still that would not explan the crash | 03:40 |
| rgareus | also you store back the global variable in the inner looop | 03:43 |
| rgareus | denoiser->i_lb2 = i_lb1; // should be done after the loop | 03:43 |
| rgareus | for each sample just use i_lb2 = i_lb1; etc | 03:44 |
| rgareus | anyway bedtime | 03:44 |
| rgareus | wend: http://pastebin.com/CnASzUA2 # untested, edited on pastebin | 03:52 |
| wend | Hey rgareus | 03:53 |
| wend | Thanks for the help man :) Gonna give it another shot | 03:53 |
| rgareus | wend: hiho | 03:53 |
| rgareus | wend: you're almost there it seems. | 03:53 |
| wend | I hope so man ^^ | 03:54 |
| rgareus | wend: looking again. i made a typo in line 60 | 03:55 |
| rgareus | wend: but there idea behind the changes should be clear anyway, I hope. | 03:56 |
| wend | Yep, I understand that I was changing the global buffers. I don't understand why you substituted input_left/right for another variable though. | 03:57 |
| rgareus | many plugin hosts do "in-place processing" the outbut buffer is identical to the input buffer | 03:58 |
| rgareus | denoiser->input_left points to the same memory as denoiser->output_left | 03:58 |
| rgareus | line 42 in your code modifies the output and thereby also modifies the input. | 03:59 |
| wend | Wow, did not know that! | 04:01 |
| rgareus | if your plugin can't do that there's http://lv2plug.in/ns/lv2core/#inPlaceBroken | 04:01 |
| rgareus | VST these days discontinued that. all VSTs are expected to process in-place | 04:02 |
| wend | Thanks for the help man :) It's behaving like a notch filter. However, it's attenuating signal a lot. The lower the center freq, the lower the amplitude. | 04:04 |
| rgareus | might be some global gain scaling is missing | 04:04 |
| wend | Is this to be expected with this kind of notch filter? | 04:04 |
| rgareus | I didn't check the DSP. | 04:04 |
| rgareus | it's not unusual that some filters require 'normalization'. | 04:05 |
| rgareus | or maybe it's just a wrong sign :) | 04:06 |
| rgareus | some plus instead of minus somwhere | 04:06 |
| rgareus | or you did the same copy/paste errors as I did :) | 04:07 |
| wend | I've seen a few notch filter cookbooks that mention scaling but the one I used for this didn't mention any. Gonna look over everything again, probably is a typo. | 04:09 |
| wend | Yep, typo on line 23. | 04:12 |
| wend | Now it's working perfectly :) You're a lifesaver, rgareus! | 04:12 |
| *** zth_studiocomp has joined #lv2 | 04:16 | |
| *** gianMOD has joined #lv2 | 05:27 | |
| *** gianMOD has quit IRC | 05:34 | |
| *** gianMOD has joined #lv2 | 05:40 | |
| *** gianMOD has quit IRC | 07:02 | |
| *** ddom has joined #lv2 | 07:08 | |
| *** gianMOD has joined #lv2 | 07:39 | |
| *** ddom has quit IRC | 07:44 | |
| *** gianMOD has quit IRC | 07:51 | |
| *** ricardocrudo has joined #lv2 | 08:00 | |
| *** falktx has joined #lv2 | 08:18 | |
| *** falktx has quit IRC | 08:32 | |
| *** wend has quit IRC | 09:27 | |
| *** edogawa has joined #lv2 | 09:47 | |
| *** falktx has joined #lv2 | 10:12 | |
| *** ricardocrudo has quit IRC | 13:12 | |
| *** ricardocrudo has joined #lv2 | 13:13 | |
| *** ricardocrudo has quit IRC | 13:23 | |
| *** ricardocrudo has joined #lv2 | 13:24 | |
| *** gianMOD has joined #lv2 | 13:26 | |
| *** ddom has joined #lv2 | 14:01 | |
| *** gianMOD has quit IRC | 14:31 | |
| *** NickSB2 has quit IRC | 14:38 | |
| *** arguy has joined #lv2 | 14:40 | |
| *** gianMOD has joined #lv2 | 15:59 | |
| *** gianMOD has quit IRC | 16:29 | |
| *** falktx has quit IRC | 16:35 | |
| *** falktx has joined #lv2 | 16:35 | |
| *** sigma6 has joined #lv2 | 17:00 | |
| *** ddom has quit IRC | 17:13 | |
| *** aombk2 is now known as aombk | 17:29 | |
| *** gianMOD has joined #lv2 | 17:30 | |
| *** gianMOD has quit IRC | 17:34 | |
| *** Magnus_RM has joined #lv2 | 18:03 | |
| *** sigma6 has quit IRC | 18:05 | |
| *** gianMOD has joined #lv2 | 18:21 | |
| *** ricardocrudo has quit IRC | 18:28 | |
| *** ricardocrudo has joined #lv2 | 18:29 | |
| *** ricardocrudo has quit IRC | 18:31 | |
| *** ddom has joined #lv2 | 18:32 | |
| *** falktx has quit IRC | 18:40 | |
| *** rncbc has joined #lv2 | 18:47 | |
| *** gianMOD has quit IRC | 18:47 | |
| *** gianMOD has joined #lv2 | 18:50 | |
| *** gianMOD has quit IRC | 18:55 | |
| *** Magnus_RM has quit IRC | 18:58 | |
| *** rncbc has quit IRC | 19:30 | |
| *** gianMOD has joined #lv2 | 19:40 | |
| *** falktx has joined #lv2 | 19:53 | |
| *** ricardocrudo has joined #lv2 | 20:38 | |
| *** gianMOD has quit IRC | 20:47 | |
| *** NickSB2 has joined #lv2 | 20:53 | |
| *** gianMOD has joined #lv2 | 21:23 | |
| *** Magnus_RM has joined #lv2 | 22:05 | |
| *** ricardocrudo has quit IRC | 22:18 | |
| *** gianMOD has quit IRC | 22:36 | |
| *** falktx has quit IRC | 23:02 | |
| *** ddom has quit IRC | 23:56 | |
Generated by irclog2html.py 2.13.0 by Marius Gedminas - find it at mg.pov.lt!